test: Move firewalld tests into one file #994
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Mingli-Yu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Ephemeral COPR build failed. @containers/packit-build please check. |
| @@ -329,3 +329,71 @@ function setup() { | |||
| expected_rc=1 run_netavark -f ${TESTSDIR}/testfiles/invalid-port.json setup $(get_container_netns_path) | |||
| assert_json ".error" "invalid host ip \"abcd\" provided for port 8080" "host ip error" | |||
| } | |||
|
|
|||
| @test "$fw_driver - test firewalld reload" { | |||
There was a problem hiding this comment.
you need to fix the test name to use the real driver and make the test use NETAVARK_FW=iptables run_netavark ... to set the correct driver.
There was a problem hiding this comment.
Thanks! The change is in the latest PR now.
test/200-bridge-firewalld.bats
Outdated
| @@ -329,3 +329,71 @@ function setup() { | |||
| expected_rc=1 run_netavark -f ${TESTSDIR}/testfiles/invalid-port.json setup $(get_container_netns_path) | |||
| assert_json ".error" "invalid host ip \"abcd\" provided for port 8080" "host ip error" | |||
| } | |||
|
|
|||
| @test "$fw_driver - test firewalld reload" { | |||
| setup_firewalld | |||
There was a problem hiding this comment.
this must be dropped now that it is part of the firewalld file
There was a problem hiding this comment.
Thanks! The change is in the latest PR now.
Moving firewalld related tests into one file should be convenient for the user who doesn't care firewalld. Signed-off-by: Mingli Yu <[email protected]>
|
ping. Thanks! |
|
@Mingli-Yu the tests are failing so there isn't much point for me to review this. It is up to you to fix that. |
|
@Luap99 Many thanks for your respond! I actually didn't fix any test cases right now, just try to group all firewalld related cases into one file. And latest PR did have the problem with the $fw_driver in the test name. Do you plan to group all firewalld related cases into one file? If yes, I will send a new PR then. |
|
I don't have any plans in that regard. These are upstream tests that work for us. If others like to make them work in their environments and send PRs to do that is fine for me but I am not interesting in spending a bunch of time to get them work in every possible scenario. |
Moving firewalld related tests into one file should be convenient for the user who doesn't care firewalld.