fix(compose): .build Quadlet file error reporting
#127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there was an error converting the `build` section of a Compose service it would not be reported to the user. The rest of the service would fail to convert to a `.container` Quadlet file as the `image` would not be set (it's set after the `build` section is successfully converted). The user would receive a "`image` or `build` is required" error as the service error would be reported first. Changed `podlet::cli::compose::services_try_into_quadlet_files()` so that if an error occurs when converting the `build` section, it is reported to the user without attempting to convert the rest of the service. Fixes: #126 Signed-off-by: Paul Nettleton <[email protected]>
|
@Timon-Schneider could you test this out? Thanks for reporting the issue! |
|
Works: #126 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there was an error converting the
buildsection of a Compose service it would not be reported to the user. The rest of the service would fail to convert to a.containerQuadlet file as theimagewould not be set (it's set after thebuildsection is successfully converted). The user would receive a "imageorbuildis required" error as the service error would be reported first.Changed
podlet::cli::compose::services_try_into_quadlet_files()so that if an error occurs when converting thebuildsection, it is reported to the user without attempting to convert the rest of the service.Fixes: #126