Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update release procedure #1945

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

deboer-tim
Copy link
Contributor

What does this PR do?

I think I was the first person to try the release procedure, and there were a few things that were out of date or clearly copied from Podman Desktop.

  • There is no label kind/release (and I don't think it's worth creating one).
  • Simplified to 'maintainers', since it's not necessarily the same set of people.
  • The release timeline was just copied from Podman Desktop and completely wrong this time - at least clarified that's when we're releasing at the same time.
  • Improved ordering of / simplified closing the release vs issues in it.
  • Version bump PR is not auto-merged, changed the wording.
  • Clarified it's the catalog that actually makes the release visible.
  • Moved checking the published image to the correct place in the workflow (before we test it).
  • Simplified/reorganized/reformatted the testing and publishing sections.
  • Minor wording improvements.

Screenshot / video of UI

N/A

What issues does this PR fix or reference?

Related to #1842.

How to test this PR?

N/A

I think I was the first person to try the release procedure, and there were a few
things that were out of date or clearly copied from Podman Desktop.

- There is no label kind/release (and I don't think it's worth creating one).
- Simplified to 'maintainers', since it's not necessarily the same set of people.
- The release timeline was just copied from Podman Desktop and completely wrong
  this time - at least clarified that's when we're releasing at the same time.
- Improved ordering of / simplified closing the release vs issues in it.
- Version bump PR is not auto-merged, changed the wording.
- Clarified it's the catalog that actually makes the release visible.
- Moved checking the published image to the correct place in the workflow
  (before we test it).
- Simplified/reorganized/reformatted the testing and publishing sections.
- Minor wording improvements.

Related to containers#1842.

Signed-off-by: Tim deBoer <[email protected]>
@deboer-tim deboer-tim requested review from benoitf, jeffmaury and a team as code owners October 17, 2024 15:21
Copy link
Contributor

@axel7083 axel7083 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the document !


## Next phase
- Create a branch if it does not exist. For example 1.2.1 if 1.2.0 failed. Then, cherry-pick bugfixes into that branch.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benoitf
Copy link
Collaborator

benoitf commented Nov 15, 2024

setting as draft as there were no updates since one month

@benoitf benoitf marked this pull request as draft November 15, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants