Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the 'max_pool_size' parameter passing for Adapters #366

Merged
merged 4 commits into from
Jan 18, 2024
Merged

Fix the 'max_pool_size' parameter passing for Adapters #366

merged 4 commits into from
Jan 18, 2024

Commits on Jan 18, 2024

  1. Fix the 'max_pool_size' parameter passing 

    Signed-off-by: Milan Balazs <[email protected]>
    @milanbalazs
    milanbalazs committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    cc8e525 View commit details
    Browse the repository at this point in the history

  2. Keep the backward compatible 

    Fix the parameter passing for HttpAdapter

Signed-off-by: Milan Balazs <[email protected]>
    @milanbalazs
    milanbalazs committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    cd11e38 View commit details
    Browse the repository at this point in the history

  3. Fix the Python Black formatting. 

    Signed-off-by: Milan Balazs <[email protected]>
    @milanbalazs
    milanbalazs committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    a26194d View commit details
    Browse the repository at this point in the history

  4. Use custom warning (ParameterDeprecationWarning) 

    With this custom warning class only the specific warning
will be shown to user (warnings.simplefilter).

It doesn't affect to other Warings in other modules.

Signed-off-by: Milan Balazs <[email protected]>
    @milanbalazs
    milanbalazs committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    2264989 View commit details
    Browse the repository at this point in the history