Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Fedora release number from task names #396

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

cevich
Copy link
Member

@cevich cevich commented May 31, 2024

With Renovate managing CI VM updates, when a major Fedora release happens, additional manual work is required to update the CI task names so they match the release number. This is extra burdensome on maintainers, stop it.

Example Ref: #389

With Renovate managing CI VM updates, when a major Fedora release
happens, additional manual work is required to update the CI task names
so they match the release number.  This is extra burdensome on
maintainers, stop it.

Signed-off-by: Chris Evich <[email protected]>
@cevich
Copy link
Member Author

cevich commented May 31, 2024

@inknos PTAL when you get a chance.

@inknos
Copy link
Contributor

inknos commented May 31, 2024

thanks

/lgtm

@cevich
Copy link
Member Author

cevich commented May 31, 2024

@inknos would you mind giving this a /approve comment also? Otherwise the merge-bot won't do anything. FYI, same thing applies for most of the other containers-org repos.

@inknos
Copy link
Contributor

inknos commented Jun 3, 2024

/approve

@inknos
Copy link
Contributor

inknos commented Jun 3, 2024

looks like we need @jwhonce for approval here :)

@rhatdan
Copy link
Member

rhatdan commented Jun 3, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Jun 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, inknos, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 3, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 17e4846 into containers:main Jun 3, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants