Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #464

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Fix typos #464

merged 1 commit into from
Nov 13, 2024

Conversation

kianmeng
Copy link
Contributor

Found via codespell -H and typos --hidden --format brief

@inknos
Copy link
Contributor

inknos commented Nov 11, 2024

@kianmeng thanks

please sign your commit :)

git commmit -s --amend --no-edit
git push origin +fix-typos

@rhatdan
Copy link
Member

rhatdan commented Nov 11, 2024

LGTM once signed

@rhatdan
Copy link
Member

rhatdan commented Nov 11, 2024

Thanks @kianmeng

@inknos
Copy link
Contributor

inknos commented Nov 12, 2024

@kianmeng I saw your latest push, but the commit is still not signed :)

Would you mind taking a look at what the bot says to help you sign the commit? https://github.com/containers/podman-py/pull/464/checks?check_run_id=32824542918

You should see Signed-off-by: Author Name <[email protected]> in your commit before pushing again

Found via `codespell -H` and `typos --hidden --format brief`

Signed-off-by: Kian-Meng Ang <[email protected]>
@jwhonce
Copy link
Member

jwhonce commented Nov 13, 2024

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwhonce, kianmeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e671a4d into containers:main Nov 13, 2024
15 checks passed
@kianmeng
Copy link
Contributor Author

🥳 🥳 🥳 🥳 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants