Skip to content

Commit

Permalink
Merge pull request #23290 from cevich/add_libkrun_task
Browse files Browse the repository at this point in the history
Add libkrun Mac task
  • Loading branch information
openshift-merge-bot[bot] authored Aug 2, 2024
2 parents 9333822 + 457c645 commit 0bc0739
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 7 deletions.
14 changes: 7 additions & 7 deletions .cirrus.yml
Original file line number Diff line number Diff line change
Expand Up @@ -790,15 +790,15 @@ podman_machine_mac_task:
persistent_worker: *mac_pw
env:
<<: *mac_env
# Consumed by podman-machine ginkgo tests
CONTAINERS_MACHINE_PROVIDER: "applehv"
# TODO: Should not require a special image, for now it does.
# Simply remove the line below when a mac image is GA.
# MACHINE_IMAGE: "https://fedorapeople.org/groups/podman/testing/applehv/arm64/fedora-coreos-38.20230925.dev.0-applehv.aarch64.raw.gz"
# Values necessary to populate std_name_fmt alias
TEST_FLAVOR: "machine-mac"
DISTRO_NV: "darwin"
PRIV_NAME: "rootless" # intended use-case
matrix:
- env:
# See contrib/cirrus/mac_runner.sh
TEST_FLAVOR: "machine-applehv"
- env:
# See contrib/cirrus/mac_runner.sh
TEST_FLAVOR: "machine-libkrun"
clone_script: # artifacts from osx_alt_build_task
- mkdir -p $CIRRUS_WORKING_DIR
- cd $CIRRUS_WORKING_DIR
Expand Down
14 changes: 14 additions & 0 deletions contrib/cirrus/mac_runner.sh
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,18 @@ function logformatter() {
"${CIRRUS_WORKING_DIR}/${SCRIPT_BASE}/logformatter" "$(output_name)"
}

# Defined by .cirrus.yml
# shellcheck disable=SC2154
case "$TEST_FLAVOR" in
machine-applehv)
export CONTAINERS_MACHINE_PROVIDER="applehv"
;;
machine-libkrun)
export CONTAINERS_MACHINE_PROVIDER="libkrun"
;;
*)
echo "Unknown/unsupported \$TEST_FLAVOR value '$TEST_FLAVOR'."
exit 1
esac

make localmachine 2>&1 | logformatter
1 change: 1 addition & 0 deletions pkg/machine/e2e/basic_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ var _ = Describe("run basic podman commands", func() {

It("Volume ops", func() {
skipIfVmtype(define.HyperVVirt, "FIXME: #21036 - Hyper-V podman run -v fails due to path translation issues")
skipIfVmtype(define.LibKrun, "FIXME: #23296 - Fails on MacOS when libkrun in use.")

tDir, err := filepath.Abs(GinkgoT().TempDir())
Expect(err).ToNot(HaveOccurred())
Expand Down

0 comments on commit 0bc0739

Please sign in to comment.