Check AppleHypervisor before accessing it

In GetDefaultDevices(), make sure MachineConfig has an AppleHypervisor instance before attempting to access it. This fixes a SIGSEGV when running with libkrun as machine provider. Signed-off-by: Sergio Lopez <[email protected]>
containers · May 20, 2024 · 3ab9e86 · 3ab9e86
1 parent f7bd15d
commit 3ab9e86
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/pkg/machine/apple/vfkit.go b/pkg/machine/apple/vfkit.go
@@ -43,8 +43,7 @@ func GetDefaultDevices(mc *vmconfigs.MachineConfig) ([]vfConfig.VirtioDevice, *d
 	}
 	devices = append(devices, disk, rng, serial, readyDevice)
 
-	rosettaCfg := mc.AppleHypervisor.Vfkit.Rosetta
-	if rosettaCfg {
+	if mc.AppleHypervisor != nil && mc.AppleHypervisor.Vfkit.Rosetta {
 		rosetta := &vfConfig.RosettaShare{
 			DirectorySharingConfig: vfConfig.DirectorySharingConfig{
 				MountTag: define.MountTag,