Avoid rebooting twice when installing WSL

For some reason, after upgrading to WiX v5, the forceReboot action appeared before the Dism actions in the msi InstallExecuteSequence table. As a consequence the user was asked to reboot before WSL or Hyper-V installation and to reboot a second time after their installation. To avoid that the ForceReboot action field `Before=StopServices` is replaced with `After=DismX86` Signed-off-by: Mario Loriedo <[email protected]>
containers · Dec 13, 2024 · 957b4da · 957b4da
1 parent 439136d
commit 957b4da
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/contrib/win-installer/podman.wxs b/contrib/win-installer/podman.wxs
@@ -116,7 +116,7 @@
 		<InstallExecuteSequence>
 			<Custom Action="CheckWSL" Before="SetWSL_INSTALL" />
 			<Custom Action="CheckHyperV" Before="SetHYPERV_INSTALL" />
-			<ForceReboot Before="StopServices" Condition="(NOT Installed) AND (NOT UpdateStarted) AND (NOT BURNMSIUNINSTALL) AND ((WSL_INSTALL = 1) OR (HYPERV_INSTALL = 1)) AND (NOT AFTERREBOOT)" />
+			<ForceReboot After="DismX86" Condition="(NOT Installed) AND (NOT UpdateStarted) AND (NOT BURNMSIUNINSTALL) AND ((WSL_INSTALL = 1) OR (HYPERV_INSTALL = 1)) AND (NOT AFTERREBOOT)" />
 		</InstallExecuteSequence>
 		<Binary Id="PodmanHooks" SourceFile="artifacts/podman-msihooks.dll" />