Skip to content

Commit

Permalink
Break v5.3.1 Windows installer upgrade to avoid reboot
Browse files Browse the repository at this point in the history
Change the name of the main package feature so that the
uninstallation of the v5.3.1 during an upgrade fail and a
reboot is not triggered. This commit explicitly specifies
to ignore the uninstallation errors during upgrade so that it
completes successfully.

References:
- https://github.com/orgs/wixtoolset/discussions/8854
- #24735

Signed-off-by: Mario Loriedo <[email protected]>
  • Loading branch information
l0rd committed Dec 5, 2024
1 parent 55b1be6 commit c2c1861
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions contrib/win-installer/podman.wxs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

<Package Name="podman" Manufacturer="Red Hat Inc." Version="$(VERSION)" UpgradeCode="a6a9dd9c-0732-44ba-9279-ffe22ea50671">
<Media Id="1" Cabinet="Podman.cab" EmbedCab="yes" />
<MajorUpgrade DowngradeErrorMessage="A newer version of [ProductName] is already installed." RemoveFeatures="Complete" Schedule="afterInstallExecute" />
<MajorUpgrade DowngradeErrorMessage="A newer version of [ProductName] is already installed." RemoveFeatures="ExecutablesDocsAndWindowsFeatures" Schedule="afterInstallExecute" IgnoreRemoveFailure="true" />
<Property Id="DiskPrompt" Value="Red Hat's Podman $(VERSION) Installation" />
<Property Id="MACHINE_PROVIDER" Value="wsl" />
<Property Id="MACHINE_PROVIDER_CONFIG_FILE_PATH">
Expand Down Expand Up @@ -84,7 +84,7 @@
<PanelSW:Dism EnableFeature="Microsoft-Hyper-V" ErrorHandling="prompt" />
</Component>
</ComponentGroup>
<Feature Id="Complete" Level="1">
<Feature Id="ExecutablesDocsAndWindowsFeatures" Level="1">
<ComponentRef Id="INSTALLDIR_Component" />
<ComponentRef Id="EnvEntriesComponent" />
<ComponentRef Id="MainExecutable" />
Expand Down

0 comments on commit c2c1861

Please sign in to comment.