Skip to content

Commit

Permalink
Merge pull request #24423 from Luap99/debug-23913
Browse files Browse the repository at this point in the history
Instrument cleanup tracer to log weird volume removal flake
  • Loading branch information
openshift-merge-bot[bot] authored Oct 31, 2024
2 parents f139bc1 + d633824 commit de99041
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 1 deletion.
14 changes: 14 additions & 0 deletions hack/podman_cleanup_tracer.bt
Original file line number Diff line number Diff line change
Expand Up @@ -149,3 +149,17 @@ tracepoint:syscalls:sys_enter_write
$offset += $len
}
}

// HACK: debug for https://github.com/containers/podman/issues/23913
// The test uses "ebpf-debug-23913" volume name and because and volume rm
// will delete the path we can trap the process here to find out who actually
// deletes it.
tracepoint:syscalls:sys_enter_unlink*
/ strcontains(str(args.pathname), "ebpf-debug-23913") /
{
printf("Special issue 23913 volume deleted by pid %d: ", pid);
// This can fail to open the file it is done in user space and
// thus racy if the process exits quickly.
cat("/proc/%d/cmdline", pid);
print("");
}
3 changes: 2 additions & 1 deletion test/system/600-completion.bats
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,8 @@ function _check_no_suggestions() {
random_image_name="i-$(safename)"
random_image_tag=$(random_string 5)
random_network_name="n-$(safename)"
random_volume_name="v-$(safename)"
# Do not change the suffix, it is special debug for #23913
random_volume_name="v-$(safename)-ebpf-debug-23913"
random_secret_name="s-$(safename)"
random_secret_content=$(random_string 30)
secret_file=$PODMAN_TMPDIR/$(random_string 10)
Expand Down

1 comment on commit de99041

@packit-as-a-service
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

podman-next COPR build failed. @containers/packit-build please check.

Please sign in to comment.