Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI:DOCS] Improve podman-{tag,build} man pages #20007

Merged
merged 2 commits into from
Sep 18, 2023
Merged

[CI:DOCS] Improve podman-{tag,build} man pages #20007

merged 2 commits into from
Sep 18, 2023

Conversation

rahilarious
Copy link
Contributor

Does this PR introduce a user-facing change?

None

@rahilarious rahilarious changed the title [CI:DOCS] Improve podman-build man page [CI:DOCS] Improve podman-* man pages Sep 17, 2023
@rahilarious rahilarious changed the title [CI:DOCS] Improve podman-* man pages [CI:DOCS] Improve podman-{tag,build} man pages Sep 17, 2023
vrothberg
vrothberg reviewed Sep 18, 2023
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

The changes LGTM. In order to pass the tests, your commits need a signature (i.e., the Signed-off-by) which you can add via git commit --amend -s (must be done for both commits).

@rahilarious
Copy link
Contributor Author

our commits need a signature

Oops. Done. I always forget that. Is there anyway to always --signoff all commit globally in git? Can't find it in git-config.

@rhatdan
Copy link
Member

rhatdan commented Sep 18, 2023

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rahilarious, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2023
@rhatdan
Copy link
Member

rhatdan commented Sep 18, 2023

Thanks @rahilarious

@openshift-merge-robot openshift-merge-robot merged commit 8434471 into containers:main Sep 18, 2023
41 checks passed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Dec 18, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg left review comments

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rahilarious @rhatdan @vrothberg @openshift-merge-robot