Makefile equiv Powershell script #20031
Conversation
openshift-ci
bot
added
release-note-none
approved
|
Continuation of #20028, since that PR didn't update with force pushes for some reason. Edit: ah, it's a GitHub outage. https://twitter.com/githubstatus/status/1704123476578083156 |
ashley-cui
force-pushed
the
winmake
branch
4 times, most recently
from
c01465f to
0dd96b6
Compare
Unix only code crept into shared portions of the machine codebase, preventing builds on Windows. Move them into unix-only files. [NO NEW TESTS NEEDED] Signed-off-by: Ashley Cui <[email protected]>
There was a problem hiding this comment.
Nice work @ashley-cui. It looks good to me aside from some a couple error handling notes I added.
|
Other than @n1hility 's comments, LGTM. But it's been a LONG time since I've written stuff in powershell. |
Introduce a powershell script that mirrors Makefile capbilities on Windows. Syntax: ./winmake target [options] [NO NEW TESTS NEEDED] Signed-off-by: Ashley Cui <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashley-cui, n1hility The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Makefile equiv Powershell script
Introduce a powershell script that mirrors Makefile capbilities on
Windows.
Syntax: ./winmake target [options]
[NO NEW TESTS NEEDED]
Does this PR introduce a user-facing change?