test: update fedoraMinimal version #20082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note-none
approved
flouthoc
approved these changes
Sep 21, 2023
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Tests do not seem happy with the change. @edsantiago PTAL |
|
Looks like this f38 image does not include |
Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
test-update-fedora-minimal
branch
from
f6256e9 to
682ca6b
Compare
|
|
|
LGTM |
|
@edsantiago are you fine with this change? |
|
Ab-so-lutely! Thank you for finding an image that works! /lgtm |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
Sep 25, 2023
PR containers#20082 bumped fedora-minimal, from f34 to f39. This worked fine for a few days, then all of a sudden CI started breaking because the f39 minimal image got rebuilt and repushed without adduser. containers#20127 was an emergency fix; this is a stabler fix. We keep using not-under-our-control container images, and we keep getting burned when those get updated in nasty ways. Here we switch to using a tagged & versioned fedora-minimal image that is under our control. Signed-off-by: Ed Santiago <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR introduce a user-facing change?