Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ActiveServiceDestination in ssh remoteConnectionUsername #20084

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Use ActiveServiceDestination in ssh remoteConnectionUsername #20084

merged 1 commit into from
Sep 21, 2023

Conversation

cgiradkar
Copy link
Contributor

Small fix, which was missed initially in PR #19997

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added release-note-none do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 21, 2023
@cgiradkar
Use ActiveServiceDestination in ssh remoteConnectionUsername
24d3347 
[NO NEW TESTS NEEDED]

Signed-off-by: Chetan Giradkar <[email protected]>
@cgiradkar cgiradkar force-pushed the hotfix-ActiveDestination branch from 156f1d6 to 24d3347 Compare September 21, 2023 10:56
@cgiradkar cgiradkar mentioned this pull request Sep 21, 2023
Merged
vrothberg
vrothberg approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2023
@rhatdan
Copy link
Member

rhatdan commented Sep 21, 2023

podman machine ssh should really take an option of an URI. Since you could have multiple machines running at the same time. (Perhaps in the future)

@vrothberg
Copy link
Member

podman machine ssh should really take an option of an URI. Since you could have multiple machines running at the same time. (Perhaps in the future)

That works already via the root flags. While parsing the flags will override the settings in containers.conf.

@rhatdan rhatdan marked this pull request as ready for review September 21, 2023 11:55
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 21, 2023
@rhatdan
Copy link
Member

rhatdan commented Sep 21, 2023

/approve
/lgtm
Thanks @cgiradkar

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgiradkar, rhatdan, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrothberg
Copy link
Member

/hold cancel

@openshift-merge-robot openshift-merge-robot merged commit 6db6645 into containers:main Sep 21, 2023
96 of 97 checks passed
@vrothberg
Copy link
Member

Thanks, @cgiradkar !

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Dec 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg approved these changes

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cgiradkar @rhatdan @vrothberg @openshift-merge-robot