-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically remove anonymous volumes when removing a container #20085
Conversation
If you are running a quadlet with anonymous volumes, then the volume will leak ever time you restart the service. This change will cause the volume to be removed. Fixes: containers#20070 Signed-off-by: Daniel J Walsh <[email protected]>
@alaviss PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan, vrothberg, ygalblum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/hold cancel |
If you are running a quadlet with anonymous volumes, then the volume will leak ever time you restart the service. This change will cause the volume to be removed.
Fixes: #20070
Does this PR introduce a user-facing change?