hyperv: machine e2e tests for set command #20117
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
baude
force-pushed
the
hypervsettest
branch
from
d820069 to
cc60216
Compare
|
Cockpit tests failed for commit cc60216af9aef5b5102d3cc8bb402e444e424567. @martinpitt, @jelly, @mvollmer please check. |
| @@ -139,8 +141,9 @@ var _ = Describe("podman machine set", func() { | |||
| }) | |||
|
|
|||
| It("set user mode networking", func() { | |||
| SkipIfNotWindows("Setting user mode networking is only honored on Windows") | |||
|
|
|||
| if testProvider.VMType() != machine.WSLVirt { | |||
There was a problem hiding this comment.
Does this test now work on Linux or other non windows environments?
baude
force-pushed
the
hypervsettest
branch
2 times, most recently
from
93d4ba5 to
f8ad895
Compare
→ transient infra DNS failure, https://issues.redhat.com/browse/TFT-2256 |
|
LGTM, but needs a rebase on main to fix CI. |
The usermode networking scenario is only for WSL. Hyperv cannot run it. Signed-off-by: Brent Baude <[email protected]>
baude
force-pushed
the
hypervsettest
branch
from
f8ad895 to
41e51f4
Compare
|
Cockpit tests failed for commit 41e51f4. @martinpitt, @jelly, @mvollmer please check. |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
The usermode networking scenario is only for WSL. Hyperv cannot run it.
Does this PR introduce a user-facing change?