hyperv: Fixes for info, inspect tests #20128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashley-cui The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
ashley-cui
force-pushed
the
mach
branch
2 times, most recently
from
d79bc2c to
9941a47
Compare
|
lgtm |
mheon
reviewed
Sep 25, 2023
|
LGTM, one comment I'd like answered before merge |
We do not guarantee that the amount of machines that exist on the system is 0 before running a test. Signed-off-by: Ashley Cui <[email protected]>
HyperV and appleHV machine inspect commands were missing podman socket info. This also fixes machine inspect tests on hyperV Signed-off-by: Ashley Cui <[email protected]>
Windows now has a winmake file for easier testing, so document that. Signed-off-by: Ashley Cui <[email protected]>
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
LGTM |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add podman socket info to machine inspect
Fix podman machine info test for hyperV
Update machine tests README
Does this PR introduce a user-facing change?