-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI:BUILD] FCOS image: enable nightly build #20134
Conversation
`wait-for-copr` is still very flaky and has failed more often than not. Ref: fedora-copr/copr#2819 This change to the fcos GHA will allow nightly builds pulling in whatever packages exist on podman-next at that time without depending on wait-for-copr. The commit id will still be recorded in podman version as well as the image tag, so auditing is not affected with this change. [NO NEW TESTS NEEDED] Signed-off-by: Lokesh Mandvekar <[email protected]>
@cevich PTAL. I guess the prepush GHA can also be clubbed into this one using conditionals, but I can leave that for later. |
cc @benoitf |
still better than nothing 👍 |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, lsm5 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
weird why wait-for-copr was triggered in the scheduled run: https://github.com/containers/podman/actions/runs/6306371287/job/17121402667 . Needs yet another followup I guess 😞 |
GHA conditions DO NOT operate as you would expect. Oh and the docs are terrible. IIRC, the key is they always evaluate to strings (or something like that). Sadly, you may need to play with them in the sandbox (or elsewhere) to get them working. Maybe try:
? |
yes #20153 |
wait-for-copr
is still very flaky and has failed more often than not. Ref: fedora-copr/copr#2819This change to the fcos GHA will allow nightly builds pulling in whatever packages exist on podman-next at that time without depending on wait-for-copr.
The commit id will still be recorded in podman version as well as the image tag, so auditing is not affected with this change.
[NO NEW TESTS NEEDED]
Does this PR introduce a user-facing change?