pkg/machine/e2e: wsl stop #20141
Merged
pkg/machine/e2e: wsl stop #20141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@n1hility ptal |
baude
force-pushed
the
wslenablestop
branch
from
2e2dcb0 to
abe8dd2
Compare
|
LGTM |
|
/hold |
openshift-ci
bot
added
do-not-merge/hold
ashley-cui
reviewed
Sep 26, 2023
allow the machine stop test to pass. small change to WSL stop on an already stopped machine to allow for it to behave like hyperv and qemu Signed-off-by: Brent Baude <[email protected]>
baude
force-pushed
the
wslenablestop
branch
from
abe8dd2 to
8bad842
Compare
|
/hold |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow the machine stop test to pass.
Does this PR introduce a user-facing change?