wsl: enable machine init tests #20158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
LGTM |
vrothberg
reviewed
Sep 27, 2023
| Expect(testMachine.SSHConfig.RemoteUsername).To((Equal(remoteUsername))) | ||
|
|
||
| }) | ||
|
|
||
| It("machine init with cpus, disk size, memory, timezone", func() { | ||
| skipIfWSL("setting hardware resource numbers and timezone are not supported on WSL") |
There was a problem hiding this comment.
How does it behave on WSL? Does it error out? Any chance we can test against the expected behavior?
There was a problem hiding this comment.
i have created #20175 for this, ok?
many of wsl's attributes are not as configurable as other providers. small tweaks and conditional tests have been added. Signed-off-by: Brent Baude <[email protected]>
baude
force-pushed
the
wslenableinit
branch
from
6242de2 to
0d4526e
Compare
|
/lgtm |
openshift-ci
bot
added
do-not-merge/hold
|
LGTM |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
many of wsl's attributes are not as configurable as other providers. small tweaks and conditional tests have been added.
Does this PR introduce a user-facing change?