-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI VMs: bump to f39 + f38 #20162
CI VMs: bump to f39 + f38 #20162
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM
Restarted the two jobs which looked like flakes
Windows Cross failure seems to persist but I do not understand it |
Looks like the pandoc package was split into several packages https://hackage.haskell.org/package/pandoc-3.0/changelog Seems to be already reported against the fedora package: https://bugzilla.redhat.com/show_bug.cgi?id=2238149 |
Thank you for finding that, @Luap99. I saw "Windows" and my brain froze up. Unless there is an urgent need to start testing on f39, I'm ok with waiting for a fixed pandoc. My VM-build PR is containers/automation_images#302 and it would be nice (IMO) to remove the special-case |
IIRC, the output from that job is consumed by the other windows tasks. I believe @ashley-cui is working on native builds for Windows, which can/should probably replace the cross-build. Is that you're eventual goal Ashley? |
The F39 image should be using updates-testing, so may even be less that "a few days". I'm also waiting for this update to land in rawhide for containers/automation_images#309 and #19751 |
@edsantiago would you consider including the Also Paul's commit can be cherry-picked here safely. |
Done (on my local branch).
Done, ibid. I am monitoring the pandoc BZ, also periodically checking bodhi for pandoc builds. If I see a build, I will rerun containers/automation_images#302 . If there's nothing by Monday, I will look into some other way to fix the Windows problem. |
Yeah, eventual builds and tests should run on native Windows |
Great, you can get that implemented before Monday, right 😉 (kidding). |
Changes LGTM |
2d63973
to
dfccd2a
Compare
Should this pass CI, here's what's important to review:
As of this writing, Windows has passed (yay) which means pandoc works. I will be asleep long before any int/sys jobs complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one small thing for consideration.
...from f38 + f37. Requires one minor e2e test change, to handle an error logging change in conmon 2.1.8. Also, this is important, requires crun-1.9.1 because of a kernel symlink change; see containers/crun#1309 The VM images here were carefully built to include that. By the time the next VM images get built, it should be default. Since we've bumped crun, remove two obsolete skips And, skip a flaky pasta test, containers#20170 Signed-off-by: Ed Santiago <[email protected]>
The `v4.3.1` version of the library defines a common `passthrough_envars()` so it doesn't need to be duplicated in podman and buildah CI. It also includes an update to build-push which should make debugging easier. Finally, these images include setting of the en_US.UTF-8 locale to enable removal of a workaroud in a future commit. Signed-off-by: Chris Evich <[email protected]>
This reverts commit ed1f514. The en_US.UTF-8 locale is now added in the images at build time, containers/automation_images#295 Signed-off-by: Paul Holzinger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming happy tests. Thanks Ed.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, edsantiago, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Tests are green again. @containers/podman-maintainers are we ready for f39? |
LGTM |
/lgtm |
38f718e
into
containers:main
...from f38 + f37.
Requires one minor e2e test change, to handle an error logging
change in conmon 2.1.8.
Also, this is important, requires crun-1.9.1 because of a kernel
symlink change; see containers/crun#1309
The VM images here were carefully built to include that. By the
time the next VM images get built, it should be default.
Signed-off-by: Ed Santiago [email protected]