podman: run --replace prints only the new container id #20189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note
approved
giuseppe
force-pushed
the
run--replace-print-only-cid
branch
from
7de16bc to
720afad
Compare
giuseppe
changed the title
giuseppe
force-pushed
the
run--replace-print-only-cid
branch
from
720afad to
de0882a
Compare
vrothberg
approved these changes
Sep 28, 2023
test/e2e/run_test.go
Outdated
| session.WaitWithDefaultTimeout() | ||
| Expect(session).Should(ExitCleanly()) | ||
|
|
||
| // make sure Podman prints only one ID | ||
| Expect(session.OutputToStringArray()).To(HaveLen(1)) |
There was a problem hiding this comment.
Nit: In case you have to repush, I'd like to check that it's really the CID.
There was a problem hiding this comment.
I'll second this. Very easy fix:
diff --git a/test/e2e/run_test.go b/test/e2e/run_test.go
index 036cd4569..423c2e44c 100644
--- a/test/e2e/run_test.go
+++ b/test/e2e/run_test.go
@@ -1622,3 +1622,3 @@ VOLUME %s`, ALPINE, volPath, volPath)
// make sure Podman prints only one ID
- Expect(session.OutputToStringArray()).To(HaveLen(1))
+ Expect(session.OutputToString()).To(HaveLen(64))
}
openshift-ci
bot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, Luap99, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
giuseppe
force-pushed
the
run--replace-print-only-cid
branch
from
de0882a to
0fc5e74
Compare
edsantiago
reviewed
Sep 28, 2023
test/e2e/run_test.go
Outdated
| session.WaitWithDefaultTimeout() | ||
| Expect(session).Should(ExitCleanly()) | ||
|
|
||
| // make sure Podman prints only one ID | ||
| Expect(session.OutputToStringArray()).To(HaveLen(64)) |
There was a problem hiding this comment.
Oops, I think this is going to fail - it should be OutputToString(), not ...Array()
UPDATE: yep, tested. It fails.
|
LGTM |
print only the new container ID when using --replace instead of the terminated container ID if it was stopped. Closes: containers#20185 Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
run--replace-print-only-cid
branch
from
0fc5e74 to
f21c1d2
Compare
|
/lgtm |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR introduce a user-facing change?