-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add annotation for play kube PVC --opt image=x #20216
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: iluminae The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
55d4715
to
2d4d1a1
Compare
…e driver Signed-off-by: Kenan Kessler <[email protected]>
2d4d1a1
to
d2fd03d
Compare
I have put this in draft until I can add a test. |
Co-authored-by: Tom Sweeney <[email protected]> Signed-off-by: Kenan Kessler <[email protected]>
Ephemeral COPR build failed. @containers/packit-build please check. |
A friendly reminder that this PR had no activity for 30 days. |
@iluminae still working on this one? |
Work got busy @rhatdan - if you guys want me to add tests for this maybe you could point me to where and what kind of test and maybe I can do it in the next two days or so. I can't believe it's been a month since I put this in, thanks for the ping. |
Could you add a test to test/system/700-play.bats or test/e2e/play_kube_test.go |
A friendly reminder that this PR had no activity for 30 days. |
add annotation to enable play kube persistentVolumeClaims to use image driver with image annotation
Added