Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add annotation for play kube PVC --opt image=x #20216

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

iluminae
Copy link

@iluminae iluminae commented Sep 29, 2023

add annotation to enable play kube persistentVolumeClaims to use image driver with image annotation

Added

Add a new annotation to allow user to specify image to use when using driver=image in PersistentVolumeClaims. Use `volume.podman.io/image` when specifying `volume.podman.io/driver: image` to tell podman what image to use as a base for the volume. This is required when using the image driver, and is unsupported on other drivers.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: iluminae
Once this PR has been reviewed and has the lgtm label, please assign lsm5 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@iluminae iluminae marked this pull request as draft October 2, 2023 17:16
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 2, 2023
@iluminae
Copy link
Author

iluminae commented Oct 2, 2023

I have put this in draft until I can add a test.

Co-authored-by: Tom Sweeney <[email protected]>
Signed-off-by: Kenan Kessler <[email protected]>
@packit-as-a-service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

Copy link

github-actions bot commented Nov 5, 2023

A friendly reminder that this PR had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Nov 5, 2023

@iluminae still working on this one?

@rhatdan rhatdan removed the stale-pr label Nov 5, 2023
@iluminae
Copy link
Author

iluminae commented Nov 5, 2023

Work got busy @rhatdan - if you guys want me to add tests for this maybe you could point me to where and what kind of test and maybe I can do it in the next two days or so.

I can't believe it's been a month since I put this in, thanks for the ping.

@rhatdan
Copy link
Member

rhatdan commented Nov 8, 2023

Could you add a test to test/system/700-play.bats or test/e2e/play_kube_test.go

Copy link

github-actions bot commented Dec 9, 2023

A friendly reminder that this PR had no activity for 30 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note stale-pr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants