Fix locale issues with WSL version detection #20240
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: n1hility The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
| @@ -50,20 +50,13 @@ func IsWSLInstalled() bool { | |||
|
|
|||
| func IsWSLStoreVersionInstalled() bool { | |||
| cmd := SilentExecCmd("wsl", "--version") | |||
| out, err := cmd.StdoutPipe() | |||
| cmd.Stdout = nil | |||
There was a problem hiding this comment.
Non-blocking nit: consider using a bytes.Buffer for stdout and stderr and write that to logrus.Debugf.
Since wsl --version triggers help, which triggers an error code, use that instead of text detection. [NO NEW TESTS NEEDED] Signed-off-by: Jason T. Greene <[email protected]>
n1hility
force-pushed
the
fix-wsl-version-detection
branch
from
e86858c to
cbca395
Compare
|
/lgtm |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
well that was fun, so much for computers thinking ... |
|
/cherry-pick v4.7 |
|
@baude: new pull request created: #20243 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
github-actions
bot
added
the
locked - please file new issue/PR
Fixes #20209
Since wsl --version triggers help, which triggers an error code, use that instead of text detection.