Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] Did I break main branch #20244

Closed
wants to merge 1 commit into from
Closed

[DNM] Did I break main branch #20244

wants to merge 1 commit into from

Conversation

baude
Copy link
Member

@baude baude commented Oct 3, 2023

Do not merge, checking to see if a PR that slipped through CI broke main

[NO NEW TESTS NEEDED]

Does this PR introduce a user-facing change?

None

Do not merge, checking to see if a PR that slipped through CI broke main

[NO NEW TESTS NEEDED]

Signed-off-by: Brent Baude <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2023
@baude baude added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 3, 2023
@rhatdan rhatdan changed the title Did I break main branch [DNM] Did I break main branch Oct 3, 2023
@baude
Copy link
Member Author

baude commented Oct 3, 2023

main is fine afterall.

@baude baude closed this Oct 3, 2023
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Jan 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant