Create Qemu command wrapper #20245
Merged
Create Qemu command wrapper #20245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakecorrenti
force-pushed
the
qemu-wrapper
branch
from
dee49fa to
e1516da
Compare
|
/approve |
openshift-ci
bot
added
the
approved
baude
reviewed
Oct 3, 2023
jakecorrenti
force-pushed
the
qemu-wrapper
branch
from
e1516da to
f4c80f2
Compare
|
Code LGTM |
jakecorrenti
force-pushed
the
qemu-wrapper
branch
from
f4c80f2 to
777138d
Compare
flouthoc
reviewed
Oct 4, 2023
flouthoc
suggested changes
Oct 4, 2023
Luap99
requested changes
Oct 4, 2023
TomSweeneyRedHat
added
the
do-not-merge/work-in-progress
|
I've added the do not merge/WIP label for the pcap file. Once that file is removed or very fully explained and the other comments from others are addressed, feel free to remove the label. |
Creates a wrapper around the Qemu command line implementation to prevent the need to hard-code the different command line options in Init and Start. Signed-off-by: Jake Correnti <[email protected]>
jakecorrenti
force-pushed
the
qemu-wrapper
branch
from
777138d to
0414f88
Compare
|
@Luap99 Thank you for the thorough review! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, jakecorrenti, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/unhold |
vrothberg
removed
the
do-not-merge/work-in-progress
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a wrapper around the Qemu command line implementation to prevent the need to hard-code the different command line options in Init and Start.
Does this PR introduce a user-facing change?