Revert --env-file changes #20256
Merged
Revert --env-file changes #20256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
This reverts commit 7ce654f. see containers#19565 Signed-off-by: Paul Holzinger <[email protected]>
This reverts commit c67ef7c. see containers#19565 Signed-off-by: Paul Holzinger <[email protected]>
This reverts commit 170a786. This was a breaking change and users are hitting it, see containers#19565 Fixes containers#19565 Signed-off-by: Paul Holzinger <[email protected]>
Now that the newline env file change is reverted we have to adapt the tests. Signed-off-by: Paul Holzinger <[email protected]>
|
@edsantiago PTAL at test changes. |
|
Test and changes LGTM. Thank you for taking care of this. |
|
LGTM |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused regressions for users, see #19565
Fixes #19565
Does this PR introduce a user-facing change?