Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI:DOCS] Remove dead link from README #20261

Merged
merged 1 commit into from
Oct 4, 2023
Merged

[CI:DOCS] Remove dead link from README #20261

merged 1 commit into from
Oct 4, 2023

Conversation

cgiradkar
Copy link
Contributor

@cgiradkar cgiradkar commented Oct 4, 2023 •
edited
Loading

The link for podman-hello.png was replaced with a textual representation but a dangling pointer to dead link was still present. This PR removes the dead link to avoid hitting 404

closes #168

Does this PR introduce a user-facing change?

None

@cgiradkar
[CI:DOCS] Remove dead link from README
3fc7c42 
The link for podman-hello.png was replaced with a textual representation but a dangling pointer to dead link was still present. This PR removes the dead link to avoid hitting 404.

Signed-off-by: Chetan Giradkar <[email protected]>
@openshift-ci openshift-ci bot added release-note-none do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 4, 2023
TomSweeneyRedHat
TomSweeneyRedHat reviewed Oct 4, 2023
View reviewed changes
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cgiradkar
Copy link
Contributor Author

@TomSweeneyRedHat I have added a tag of closes to the PR top description, but that number is from podman.io issues page, not sure if the bot will close podman bug by the same number, could you please clarify?

@cgiradkar cgiradkar marked this pull request as ready for review October 4, 2023 17:58
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 4, 2023
@ashley-cui
Copy link
Member

/lgtm

Not sure about the bot, but if it doesn't close the issue on podman.io we can close it manually.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2023
@ashley-cui
Copy link
Member

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashley-cui, cgiradkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2023
@openshift-ci openshift-ci bot merged commit 6d3cea3 into containers:main Oct 4, 2023
42 checks passed
@TomSweeneyRedHat
Copy link
Member

Looks like the bot was happy to nuke the issue on podman.io, at least it's closed at this point.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Jan 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TomSweeneyRedHat TomSweeneyRedHat TomSweeneyRedHat left review comments

Assignees

@ashley-cui ashley-cui

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Podman Hello not found
3 participants
@cgiradkar @ashley-cui @TomSweeneyRedHat