Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CI VMs: new pasta, crun, rawhide kernel #22082

Closed
wants to merge 1 commit into from

Conversation

edsantiago
Copy link
Member

@edsantiago edsantiago commented Mar 18, 2024

Pasta 03-20, crun 1.14.4

One unexplained difference: fc39 and rawhide now create:

    /run/log/journal/SOMETHING/system.journal

...and the SOMETHING is o-rwx. This triggers journalctl to spit out a warning:

Hint: You are currently not seeing messages from the system.
      Users in groups 'adm', 'systemd-journal', 'wheel' can see all messages.
      Pass -q to turn off this notice.

...which in turn causes ExitCleanly() to fail.

It is not clear who/what is creating this journal directory, or
why it allofasudden started just now.

VM package info: containers/automation_images#337 (comment)

Signed-off-by: Ed Santiago [email protected]

None

Copy link
Contributor

openshift-ci bot commented Mar 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2024
@edsantiago
Copy link
Member Author

crun is now 1.14.4 (dot-FOUR) everywhere. This should help us out on buildah; some tests are being skipped there because of a too-old crun on debian.

Copy link

Cockpit tests failed for commit d78866aa5e315cfc84394add7172bf258203c7a3. @martinpitt, @jelly, @mvollmer please check.

@edsantiago edsantiago marked this pull request as draft March 19, 2024 12:34
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2024
@edsantiago
Copy link
Member Author

Converted to draft while the pasta issue gets sorted out

Copy link

Cockpit tests failed for commit 11248931491a872767a79d4ca1f5e8269baa9161. @martinpitt, @jelly, @mvollmer please check.

Copy link

Cockpit tests failed for commit d55dbaf8ca8bd749e0b15292b20a5ad64da68a43. @martinpitt, @jelly, @mvollmer please check.

@edsantiago edsantiago marked this pull request as ready for review March 20, 2024 18:38
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2024
Copy link
Member Author

@edsantiago edsantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@containers/podman-maintainers PTAL.

Highlights of new VMs:

  • pasta 03-20 on all Fedoras (02-20 on Debian)
  • crun 1.14.4 (dot FOUR) everywhere
  • kernel 6.9 on rawhide

Nothing else supernoteworthy IMO, but see auto-images 337 for full list.

contrib/cirrus/lib.sh Outdated Show resolved Hide resolved
@@ -38,7 +38,8 @@ var _ = Describe("Podman run device", func() {
session.WaitWithDefaultTimeout()
Expect(session).Should(ExitCleanly())
if !isRootless() {
session = podmanTest.Podman([]string{"run", "-q", "--security-opt", "label=disable", "--device", "/dev/kmsg", "--cap-add", "SYS_ADMIN", ALPINE, "head", "-n", "1", "/dev/kmsg"})
// Kernel 6.9.0 (2024-03) requires SYSLOG
session = podmanTest.Podman([]string{"run", "-q", "--security-opt", "label=disable", "--device", "/dev/kmsg", "--cap-add", "SYS_ADMIN,SYSLOG", ALPINE, "head", "-n", "1", "/dev/kmsg"})
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not test if rawhide requires both, or just the new one. Since these tests have to run everywhere, and both works, I'm leaving it this way.

@edsantiago edsantiago changed the title Test new VMs Bump CI VMs: new pasta, crun, rawhide kernel Mar 22, 2024
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 22, 2024
@edsantiago
Copy link
Member Author

Re-pushed with a smaller, safer fix for the journalctl problem. See commit message or PR description for details.

Be aware, these VMs include a new Debian flake, #22165. It will probably not affect PRs, because it happens (so far) only in int tests so it will be retried.

@edsantiago edsantiago force-pushed the new-vms branch 6 times, most recently from 6dd6002 to acfd099 Compare March 27, 2024 18:31
Pasta 03-20, crun 1.14.4, and /tmp on tmpfs

One unexplained difference: fc39 and rawhide now create:

    /run/log/journal/SOMETHING/system.journal

...and the SOMETHING is o-rwx. This triggers journalctl to spit out a warning:

    Hint: You are currently not seeing messages from the system.
          Users in groups 'adm', 'systemd-journal', 'wheel' can see all messages.
          Pass -q to turn off this notice.

...which in turn causes ExitCleanly() to fail.

It is not clear who/what is creating this journal directory, or
why it allofasudden started just now. Workaround is to add -q
to journalctl in one test.

VM package info:
    containers/automation_images#337 (comment)

Signed-off-by: Ed Santiago <[email protected]>
@edsantiago
Copy link
Member Author

Closing in favor of #22202

@edsantiago edsantiago closed this Mar 28, 2024
@edsantiago edsantiago deleted the new-vms branch March 28, 2024 17:37
@edsantiago edsantiago mentioned this pull request May 15, 2024
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Jun 27, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants