Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix remote build isolation on client side #22133

Merged

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Mar 22, 2024

Follow up to 493179b which only fixed the issue on the server despite me trying to fix it on the client as well, with this change here we always correctly unset the default on the remote client as the root/rootless status will be wrong.

This means it is enough for users to either have a new server or client with the bug fix which should make the update process easier.

Does this PR introduce a user-facing change?

None

Follow up to 493179b which only fixed the issue on the server despite
me trying to fix it on the client as well, with this change here we
always correctly unset the default on the remote client as the
root/rootless status will be wrong.

This means it is enough for users to either have a new server or client
with the bug fix which should make the update process easier.

Signed-off-by: Paul Holzinger <[email protected]>
Copy link
Contributor

openshift-ci bot commented Mar 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2024
@Luap99 Luap99 added the No New Tests Allow PR to proceed without adding regression tests label Mar 22, 2024
@mheon
Copy link
Member

mheon commented Mar 22, 2024

LGTM

@cdrage
Copy link

cdrage commented Mar 22, 2024

Follow up to 493179b which only fixed the issue on the server despite me trying to fix it on the client as well, with this change here we always correctly unset the default on the remote client as the root/rootless status will be wrong.

This means it is enough for users to either have a new server or client with the bug fix which should make the update process easier.

Does this PR introduce a user-facing change?

None

Thank you so much for the follow up!

This works now and has solved my issue (podman client building against podman machine rootful on v5.0.0) 🚀 🚀 🚀

@cdrage
Copy link

cdrage commented Mar 22, 2024

I'm assuming backported as well?

@Luap99
Copy link
Member Author

Luap99 commented Mar 22, 2024

I'm assuming backported as well?

yes we should do that

/cherry-pick v5.0

@openshift-cherrypick-robot
Copy link
Collaborator

@Luap99: once the present PR merges, I will cherry-pick it on top of v5.0 in a new PR and assign it to you.

In response to this:

I'm assuming backported as well?

yes we should do that

/cherry-pick v5.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@baude
Copy link
Member

baude commented Mar 22, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit d42a400 into containers:main Mar 22, 2024
94 checks passed
@openshift-cherrypick-robot
Copy link
Collaborator

@Luap99: new pull request created: #22143

In response to this:

I'm assuming backported as well?

yes we should do that

/cherry-pick v5.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Luap99 Luap99 deleted the remote-buildah-isolation-client branch March 22, 2024 22:32
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Jun 21, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
5.0 5.0.1 approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. No New Tests Allow PR to proceed without adding regression tests release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants