Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v5.3] fix CI and backport quadlet build fix #24668

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Nov 25, 2024

Backport of
#24653
#24643

Does this PR introduce a user-facing change?

Fixes an issue where quadlet build files created an invalid podman command line when `Pull=` was used. https://github.com/containers/podman/issues/24599

Luap99 and others added 2 commits November 25, 2024 11:56
Do not pull from a moving target, use a defined version so updates must
happen in a PR and do not break others.

Signed-off-by: Paul Holzinger <[email protected]>
(cherry picked from commit 916b805)
Signed-off-by: Paul Holzinger <[email protected]>
Signed-off-by: Ygal Blum <[email protected]>
(cherry picked from commit 13affe9)
Signed-off-by: Paul Holzinger <[email protected]>
@openshift-ci openshift-ci bot added release-note approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 25, 2024
Copy link
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

openshift-ci bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lsm5
Copy link
Member

lsm5 commented Nov 25, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c2f09d7 into containers:v5.3 Nov 25, 2024
76 checks passed
@Luap99 Luap99 deleted the v5.3 branch November 25, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants