manifest add: add a --artifact-annotation for --artifact #24788
+138
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nalind The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nalind
force-pushed
the
manifest-add-artifact-annotation
branch
3 times, most recently
from
1b4bd4c to
1bb9095
Compare
When adding an artifact to a manifest list / image index with `manifest add --artifact` provide a `--artifact-annotation` flag which can be used to set annotations in the artifact manifest that we're generating. Fix a client-side hang when using --artifact. Signed-off-by: Nalin Dahyabhai <[email protected]>
nalind
force-pushed
the
manifest-add-artifact-annotation
branch
from
1bb9095 to
bd347db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding an artifact to a manifest list / image index with
manifest add --artifactprovide a--artifact-annotationflag which can be used to set annotations in the artifact manifest that we're generating.Does this PR introduce a user-facing change?