Add man pages to Mac installer #24789
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
contrib/pkginstaller/package.sh
Outdated
|
|
||
| version=$(cat "${BASEDIR}/VERSION") | ||
| arch=$(cat "${BASEDIR}/ARCH") | ||
|
|
||
| function build_podman() { | ||
| pushd "$1" | ||
|
|
||
| make docs | ||
| mkdir -p "contrib/pkginstaller/out/packaging/${docDir}" | ||
| cp -v docs/build/man/*.1 "contrib/pkginstaller/out/packaging/${docDir}" |
There was a problem hiding this comment.
This seems to assume that we only ship .1 pages which is not true, we also have podman-systemd.unit.5.md
There was a problem hiding this comment.
i think for the mac client, this makes sense?
This PR adds the man1 pages to the mac installer. It also sticks a small configuration file into /usr/local/etc/man.d that allows macos and the man binary to look for the podman pages in /opt/podman/docs/man. Fixes containers#24756 Signed-off-by: Brent Baude <[email protected]>
|
LGTM |
|
/lgtm |
|
/cherry-pick v5.3 |
|
@baude: new pull request created: #24820 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This PR adds the man1 pages to the mac installer. It also sticks a small configuration file into
/usr/local/etc/man.dthat allows macos and the man binary to look for the podman pages in/opt/podman/docs/man.Fixes #24756
Does this PR introduce a user-facing change?