quadlet: fix inter-dependency of containers in Network=

[ruihe774]

This PR fixes a bug introduced by #23814.

Unlike network quadlet units, which are sorted before container quadlet units so that the ResourceName of which are guaranteed to be present when used in addNetworks(), there is no guaranteed resolving order between containers. As a result, ResourceName of a container when used in addNetworks() may be empty because the container is not resolved (i.e. ConventContainer() is not called for it) yet.

This PR fixes this by adding special handling to resolve the resource name in addNetworks() for containers.

@ygalblum PTAL

Fix a bug that when reusing another container's network in Quadlet, an error of "cannot get the resource name" may appear.

[packit-as-a-service]

Ephemeral COPR build failed. @containers/packit-build please check.

[rhatdan]

@Luap99 PTAL

[rhatdan]

You have lint errors.

[mheon]

LGTM

[ruihe774]

You have lint errors.

Sorry. Fixed.

[Luap99]

Tests are failing

[ygalblum]

Instead of addressing this only when needed, the way to address this issue is the same as we did for .build units. That is get the resource name before actually processing the units. This is handled as part of the generateUnitsInfoMap method in cmd/quadlet/main.go (

podman/cmd/quadlet/main.go

Line 584 in 07dddeb

func generateUnitsInfoMap(units []*parser.UnitFile) map[string]*quadlet.UnitInfo {

).

[ygalblum]

As mentioned, this is not the way to address this issue. I mark is as "Request Changes" to make sure it is not merged

[ruihe774]

Instead of addressing this only when needed, the way to address this issue is the same as we did for .build units. That is get the resource name before actually processing the units. This is handled as part of the generateUnitsInfoMap method in cmd/quadlet/main.go (

podman/cmd/quadlet/main.go

Line 584 in 07dddeb

func generateUnitsInfoMap(units []*parser.UnitFile) map[string]*quadlet.UnitInfo {

).

Thanks for pointing this out. I'll rework this PR.

[ruihe774]

I have no idea why two tasks have failed.

[ygalblum]

LGTM

[ygalblum]

I have no idea why two tasks have failed.

Not sure either, I've rerun the failed ones

[Luap99]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, ruihe774, ygalblum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Luap99,ygalblum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment