Add a Windows Installer patch to avoid unrequested reboots #24827
Conversation
Signed-off-by: Mario Loriedo <[email protected]>
Adding a patch to the bundle so that the update from previous version (v5.3.1) is a minor update, not a major one. A minor update prevents the full uninstallation of v5.3.1 and an unrequested reboot of the machine. Signed-off-by: Mario Loriedo <[email protected]>
When building an installer from main branch, and using it to upgrade the latest Podman release on Windows, a reboot is triggered if WSL is not installed. This is a regression caused by an update of the condition to execute `ForceReboot`. This commit fixes the condition and updates some defaults to make it even more unlikely that reboot happens withtout a specific user request for it. It doesn't fix the v5.3.1 to v5.3.2 upgrade though. v5.3.1 has been released already and this commit doesn't avoid that it triggers a reboot when updated. Signed-off-by: Mario Loriedo <[email protected]>
For some reason, after upgrading to WiX v5, the forceReboot action appeared before the Dism actions in the msi InstallExecuteSequence table. As a consequence the user was asked to reboot before WSL or Hyper-V installation and to reboot a second time after their installation. To avoid that the ForceReboot action field `Before=StopServices` is replaced with `After=DismX86` Signed-off-by: Mario Loriedo <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: l0rd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
l0rd
force-pushed
the
win-installer-patch
branch
from
c071db0 to
78f37fe
Compare
This reverts commit 916b805. Signed-off-by: Mario Loriedo <[email protected]>
l0rd
force-pushed
the
win-installer-patch
branch
from
78f37fe to
5f79cd3
Compare
|
cc @n1hility if you have the chance to give it a look. |
|
I cannot really review any of these changes but please mark this as |
|
not a wix SME but LGTM |
|
/cherry-pick v5.3 |
|
@baude: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
@baude: new pull request created: #24840 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The problem
When upgrading from v5.3.1 to a new version on a Windows machine without WSL, the installer asks to reboot. This problem doesn't impact users because v5.3.1 is the last release, but it is blocking the release v5.3.2.
Why it happens
The
ForceRebootaction in the v5.3.1 package is executed during a "major upgrade" to a new version (if WSL is not installed).Changes introduced by this PR
ForceRebootaction condition to avoid it during updatesv5.3.1so that updates from that version don't trigger an unrequested reboot.v5.3.1locally first because of this issue and change the Product ID inpodman.wxs(as described in this PRcontrib/win-installer/README.mdpreparation section).This PR supersedes #24778
Reference: https://github.com/orgs/wixtoolset/discussions/8854
Fixes #24735
Does this PR introduce a user-facing change?