-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: Initial e2e code #34
Conversation
dougsland
commented
May 7, 2023
/cc @rhatdan for review |
/hold |
Not a review, just a note: it would be great to integrate these tests with Packit and TMT (https://packit.dev/docs/testing-farm/) . Doesn't have to be in this PR, and fwiw, we don't have e2e testing with packit complete in any of our repos yet. |
Thanks @lsm5. Indeed, it will require a different github issue (as soon we merge) as I will need to research the tool to start using it. |
@dougsland Still a WIP? |
containers/container-selinux#230 might be of some use. It's not merged yet and actually running those tests does cause |
@rhatdan almost there, we need a README and a fresh test "tomorrow". As today I got surprised with some changes in the new rpm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please also add in the commit message how to actually run the test (which dir to run from), as root / non-root etc?
and also in the README |
Cleanup @lsm5 issues, and then we can merge. We need to get this test to run on PRs. |
I think if we need something running quickly, github actions might be the way, although I don't think it's easy to provision anything other than Ubuntu over there. Packit + TMT might be the way to go long-term. |
Just run ./run-e2e-test in the dir. There is a asciicinema embedded in the README that show as 'video' how to run it. |
The script will warn if user try to run as non root. |
GH-Issue: #33 Signed-off-by: Douglas Schilling Landgraf <[email protected]>
@rhatdan @lsm5 here how the HTML will look like when README.md is merged: https://github.com/dougsland/qm/tree/e2e/tests/e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM