Failover to OCI when push fails with default push mechanism

[rhatdan]

Summary by Sourcery

Enhancements:

• Implement failover mechanism to OCI when the default push mechanism fails.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR implements a failover mechanism in the push operation. When the default push mechanism fails with a KeyError, the system attempts to push the model as a container image using OCI (Open Container Initiative) format. This provides a fallback option for handling push operations when the primary method fails.

Sequence diagram for failover mechanism in push operation

sequenceDiagram
    participant User
    participant CLI
    participant NewModel
    participant OCIModel

    User->>CLI: push_cli(args)
    CLI->>NewModel: New(tgt, args)
    NewModel->>NewModel: push(source, args)
    alt Push succeeds
        NewModel-->>CLI: Success
    else Push fails with KeyError
        CLI->>OCIModel: OCI(model, config)
        OCIModel->>OCIModel: push(args)
        alt OCI Push succeeds
            OCIModel-->>CLI: Success
        else OCI Push fails
            OCIModel-->>CLI: Raise KeyError
        end
    end

Loading

File-Level Changes

Change	Details	Files
Added error handling and failover logic for push operations	Wrapped the original push operation in a try-except block Added fallback logic to attempt pushing as OCI container image when default push fails Implemented model type checking before attempting OCI fallback Added container manager configuration support for OCI push	ramalama/cli.py
Code cleanup in model class	Removed unnecessary blank line in remove method	ramalama/model.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @rhatdan - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider adding logging when falling back to OCI push to make it clear to users when this occurs
• The error handling could be improved - catching a broad Exception and re-raising the original KeyError could mask important errors. Consider handling specific exceptions and providing more informative error messages

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

suggestion: Consider adding logging or user feedback when falling back to container image handling for better debugging experience.

Suggested change

	# attempt to push as a container image
	logger.info("Falling back to container image handling for model push")
	# attempt to push as a container image