Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow toolbox containers to be created with a custom hostname #1007

Closed
wants to merge 3 commits into from

Commits on Jan 28, 2022

  1. feat: allow custom hostnames for new containers

    The new `--hostname` flag is now available when invoking `toolbox
    create` in order to create a container with a custom hostname. The new
    flag does not enforce network-resolvability of any custom hostnames,
    but it does require that the hostname is valid, per RFC 1123.
    
    To preserve backward-compatibility, the hostname will still default to
    "toolbox" if the flag is not specified.
    
    Signed-off-by: Buckley Ross <[email protected]>
    Change-Id: Ib3c0706e3a93a5748453e39998b9893e3e57c305
    buck-ross committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    244bb82 View commit details
    Browse the repository at this point in the history
  2. test: add tests for toolbox create --hostname ??

    These tests ensure that the new `--hostname` flag works as intended.
    
    Signed-off-by: Buckley Ross <[email protected]>
    Change-Id: Id7b7775fe73a6600afe2dabb0d905be5ba17bb57
    buck-ross committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    4f2cf0f View commit details
    Browse the repository at this point in the history
  3. doc: cover new toolbox create --hostname flag

    Updated the `toolbox create` manual page to cover the usage of the new
    `--hostname` flag for specifying custom hostnames when creating new
    containers.
    
    Signed-off-by: Buckley Ross <[email protected]>
    Change-Id: I16d7f63769c17aec1ff69d34ac8fe28f48827777
    buck-ross committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    a648118 View commit details
    Browse the repository at this point in the history