cmd/create, cmd/initContainer: Mount the devpts file system at runtime #1257
Conversation
|
Build succeeded. ✔️ unit-test SUCCESS in 8m 52s |
debarshiray
force-pushed
the
wip/rishi/issues-1016-00
branch
from
0953dc4
to
0e68dc9
Compare
|
Build succeeded. ✔️ unit-test SUCCESS in 8m 49s |
Debug logs are sweeter when they are shorter. containers#1258
Anything that's specified during 'podman create ...' gets statically
baked into the container's configuration, and is either difficult or
impossible to change afterwards. This means that Toolbx containers
created with older versions of Toolbx keep diverging from those created
with newer versions. Hence, making it complicated to keep older
containers working with newer Toolbx.
Mounting the devpts file system at runtime as part of the Toolbx
container's entry point will make it possible to update the attributes
of the mount, if necessary, for both existing and newly created
containers.
For what it's worth, this does alter the mount options by removing
'context'.
With 'podman create --mount type=devpts,destination=/dev/pts' it was:
$ mount | grep
...
devpts on /dev/pts type devpts (rw,nosuid,noexec,relatime,
context="system_u:object_r:container_file_t:s0:c1022,c1023",
gid=100005,mode=620,ptmxmode=666)
Now with 'mount -t devpts -o noexec,nosuid,gid=5,mode=620,ptmxmode=666'
it is:
$ mount | grep
devpts on /dev/pts type devpts (rw,nosuid,noexec,relatime,seclabel,
gid=100005,mode=620,ptmxmode=666)
containers#1016
debarshiray
force-pushed
the
wip/rishi/issues-1016-00
branch
from
0e68dc9
to
cf6db37
Compare
|
Build succeeded. ✔️ unit-test SUCCESS in 7m 26s |
Anything that's specified during
podman create ...gets staticallybaked into the container's configuration, and is either difficult or
impossible to change afterwards. This means that Toolbx containers
created with older versions of Toolbx keep diverging from those created
with newer versions. Hence, making it complicated to keep older
containers working with newer Toolbx.
Mounting the
devptsfile system at runtime as part of the Toolbxcontainer's entry point will make it possible to update the attributes
of the mount, if necessary, for both existing and newly created
containers.
For what it's worth, this does alter the mount options by removing
context.With
podman create --mount type=devpts,destination=/dev/ptsit was:Now with
mount -t devpts -o noexec,nosuid,gid=5,mode=620,ptmxmode=666it is:
#1016