Use container name as container hostname #383
Conversation
|
Build failed.
|
Jmennius
force-pushed
the
init-hostname-with-container-name
branch
from
f1da4c2
to
f318765
Compare
|
Build failed.
|
|
Good idea |
Jmennius
force-pushed
the
init-hostname-with-container-name
branch
from
f318765
to
66c5356
Compare
|
Updated this to a Go-based version (was using this for a long time). Although, with |
|
Build succeeded. ✔️ unit-test SUCCESS in 7m 11s |
..to distinguish different toolboxes more easily inside a toolbox, this includes version information too (by default). Replace underscores with dashes since underscores are not allowed in hostnames. Fixes: containers#98, containers#120 Signed-off-by: Ievgen Popovych <[email protected]>
Jmennius
force-pushed
the
init-hostname-with-container-name
branch
from
66c5356
to
3593746
Compare
|
Build succeeded. ✔️ unit-test SUCCESS in 7m 20s |
There was a problem hiding this comment.
Thanks for working on this, @Jmennius ; and my apologies for the delay.
I know that your immediate need has been addressed already. Would you still be interested in updating this pull request to implement #969 ?
Even if we don't use the hostname of the container directly in the shell prompt, #969 still brings up some good points about the default hostname.
#1086 is very close to implementing #969 Let's focus on that one. Regardless, thanks for all your contributions to the Toolbx project, @Jmennius It's a pleasure to have you around. :) |
..to distinguish different toolboxes more easily inside a toolbox,
this includes version information too (by default).
Replace underscores with dashes since underscores are not allowed in hostnames.
Fixes: #98, #120