Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHPCQ #55

Closed
wants to merge 2 commits into from
Closed

Fix PHPCQ #55

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa474cb
Fix PHPCQ
zonky2 Aug 26, 2024
914eab7
Fix PHPCQ
zonky2 Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .phpcq.yaml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ phpcq:
composer-require-checker:
version: ^1.0
signed: false
requirements:
composer-require-checker:
signed: false
version: ^4.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warum wird hier eine spezifische Version benötigt? Eigentlich macht ja PHPCQ eine korrekte Auflösung?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bei mir springt er nicht automatisch auf die nächste Version - das hat @discordier bei mir so eingetragen

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich würde es dennoch mal weglassen. Dann sollte es wohl eher ein Problem in phpcq sein, dass er hier nicht die aktuellste Version nimmt. Kenne ich aber in meinen Projekte nicht.

phpmd:
version: ^1.0
signed: false
Expand Down Expand Up @@ -47,6 +51,7 @@ phpcq:
# PHP_CodeSniffer
- 31C7E470E2138192
- 5E6DDE998AB73B8E
- A978220305CD5C32
# Composer normalize
- C00543248C87FB13
# PHPMD
Expand Down
Loading