refactor: improve prop values ternary updates

contentful · Jun 17, 2024 · cec812d · cec812d
1 parent 1f83157
commit cec812d
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/packages/forma-36-codemod/utils/updateTernaryValues.js b/packages/forma-36-codemod/utils/updateTernaryValues.js
@@ -9,13 +9,11 @@ function isConditionalExpression(value, j) {
 }
 
 const getValueFor = (key, { j, expression, valueMap = {} }) => {
-  if (isConditionalExpression(expression.value[key], j)) {
-    return updateTernaryValues(expression, { j, valueMap });
+  if (valueMap[expression.value[key].value]) {
+    const value = valueMap[expression.value[key].value];
+    return value.type === 'Identifier' ? value : j.literal(value);
   }
-
-  const value =
-    valueMap[expression.value[key].value] || expression.value[key].value;
-  return value.type === 'Identifier' ? value : j.literal(value);
+  return expression.value[key];
 };
 
 /**