feat(formControl): adds density support for Form control elements #2650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…density-form-control
🦋 Changeset detectedLatest commit: ff50ebf The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
…density-form-control
…density-form-control
…l/forma-36 into feat/high-density-form-control
stephanLeece
requested review from
cf-remylenoir,
damann and
a team
as code owners
|
@damann UI changes are here: https://www.chromatic.com/review?appId=5fd1dda724cc620021ace8c5&number=2650&type=linked Note that the Horizontal margin for the Validation message has increased to 8px for the low-density version, and 4px for the high. Previously it was at 4px as the default. |
stephanLeece
changed the title
There was a problem hiding this comment.
One comment regarding the new dependency in the lock file, besides that it is all good 👍 I will let @damann review the snapshots.
8 tasks
damann
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR
This PR adds density support to the FormControl Element.
Fort size, line height, icon size and spacing will be reduced when the component is wrapped in a density container.
Adds example FormControl story
Updates Stories that import
DensityContainerto use relative import father than from package, to fix changeset generation errorsTicket: https://contentful.atlassian.net/browse/CFCX-957
PR Checklist
readme.mdfile(s)