Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom omit utility type #2733

Merged
merged 6 commits into from
Apr 29, 2024

Conversation

cf-remylenoir
Copy link
Collaborator

@cf-remylenoir cf-remylenoir commented Apr 26, 2024

Purpose of PR

We need this custom Omit utility type to support upcoming library updates where some extended-type properties get lost when using Omit.

Reading 🍿

Copy link

changeset-bot bot commented Apr 26, 2024

🦋 Changeset detected

Latest commit: 26cc8bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@contentful/f36-core Patch
@contentful/f36-accordion Patch
@contentful/f36-asset Patch
@contentful/f36-autocomplete Patch
@contentful/f36-badge Patch
@contentful/f36-button Patch
@contentful/f36-card Patch
@contentful/f36-collapse Patch
@contentful/f36-copybutton Patch
@contentful/f36-datetime Patch
@contentful/f36-datepicker Patch
@contentful/f36-drag-handle Patch
@contentful/f36-entity-list Patch
@contentful/f36-empty-state Patch
@contentful/f36-forms Patch
@contentful/f36-icon Patch
@contentful/f36-list Patch
@contentful/f36-menu Patch
@contentful/f36-modal Patch
@contentful/f36-note Patch
@contentful/f36-notification Patch
@contentful/f36-pagination Patch
@contentful/f36-pill Patch
@contentful/f36-popover Patch
@contentful/f36-skeleton Patch
@contentful/f36-spinner Patch
@contentful/f36-table Patch
@contentful/f36-tabs Patch
@contentful/f36-text-link Patch
@contentful/f36-tooltip Patch
@contentful/f36-typography Patch
@contentful/f36-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Apr 29, 2024 8:16am

@cf-remylenoir cf-remylenoir self-assigned this Apr 26, 2024
@cf-remylenoir cf-remylenoir marked this pull request as ready for review April 26, 2024 14:23
@cf-remylenoir cf-remylenoir requested review from damann and a team as code owners April 26, 2024 14:23
Copy link

github-actions bot commented Apr 26, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 132.89 KB (0%) 2.7 s (0%) 68 ms (+66.91% 🔺) 2.8 s
Module 129.59 KB (0%) 2.6 s (0%) 70 ms (+51.53% 🔺) 2.7 s

Copy link
Collaborator

@denkristoffer denkristoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't want to keep the name MappedOmit?

@cf-remylenoir
Copy link
Collaborator Author

You don't want to keep the name MappedOmit?

I don't have a strong opinion on this one, I renamed it.

@cf-remylenoir cf-remylenoir merged commit 80c7f67 into main Apr 29, 2024
12 checks passed
@cf-remylenoir cf-remylenoir deleted the feat-add-custom-omit-utility-type branch April 29, 2024 08:59
@cf-remylenoir
Copy link
Collaborator Author

Ugh, I forgot to export the actual type from the barrel file 😄

@cf-remylenoir cf-remylenoir mentioned this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants