-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add custom omit utility type #2733
Conversation
🦋 Changeset detectedLatest commit: 26cc8bc The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't want to keep the name MappedOmit
?
I don't have a strong opinion on this one, I renamed it. |
Ugh, I forgot to export the actual type from the barrel file 😄 |
Purpose of PR
We need this custom Omit utility type to support upcoming library updates where some extended-type properties get lost when using Omit.
Reading 🍿
Omit
helper loses type information when used with extended Records. microsoft/TypeScript#36981Omit
microsoft/TypeScript#54451