Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): add BookOpenIcon #2849

Merged
merged 2 commits into from
Aug 23, 2024
Merged

feat(icons): add BookOpenIcon #2849

merged 2 commits into from
Aug 23, 2024

Conversation

andipaetzold
Copy link
Contributor

@andipaetzold andipaetzold commented Aug 23, 2024

Purpose of PR

Adding a new icon: BookOpen

Storybook screenshot:

image

PR Checklist

  • I have read the relevant readme.md file(s)
  • All commits follow our Git commit message convention
  • Tests are added/updated/not required
  • Tests are passing
  • Storybook stories are added/updated/not required
  • Usage notes are added/updated/not required
  • Has been tested based on Contentful's browser support
  • Doesn't contain any sensitive information

Copy link

vercel bot commented Aug 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Aug 23, 2024 0:51am

Copy link

changeset-bot bot commented Aug 23, 2024

⚠️ No Changeset found

Latest commit: e7a5f3c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package "@contentful/f36-components" depends on the ignored package "@contentful/f36-avatar", but "@contentful/f36-components" is not being ignored. Please add "@contentful/f36-components" to the `ignore` option.
The package "@contentful/f36-components" depends on the ignored package "@contentful/f36-image", but "@contentful/f36-components" is not being ignored. Please add "@contentful/f36-components" to the `ignore` option.
The package "@contentful/f36-components" depends on the ignored package "@contentful/f36-header", but "@contentful/f36-components" is not being ignored. Please add "@contentful/f36-components" to the `ignore` option.

@andipaetzold andipaetzold changed the base branch from main to next August 23, 2024 11:57
@andipaetzold andipaetzold self-assigned this Aug 23, 2024
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 516.97 KB (+277.93% 🔺) 10.4 s (+277.93% 🔺) 1.2 s (+163.39% 🔺) 11.5 s
Module 512.57 KB (+285.32% 🔺) 10.3 s (+285.32% 🔺) 1.7 s (+205.43% 🔺) 11.9 s

@andipaetzold andipaetzold marked this pull request as ready for review August 23, 2024 12:11
@andipaetzold andipaetzold requested review from damann and a team as code owners August 23, 2024 12:11
@andipaetzold andipaetzold requested review from giotiskl, stephanLeece and mdmjg and removed request for a team August 23, 2024 12:11
Copy link
Collaborator

@Lelith Lelith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andipaetzold andipaetzold merged commit 79ed192 into next Aug 23, 2024
8 of 11 checks passed
@andipaetzold andipaetzold deleted the CFISO-1687 branch August 23, 2024 12:51
Lelith pushed a commit that referenced this pull request Oct 23, 2024
* feat(icons): add `BookOpenIcon`

* chore: release new version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants