Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove GitLab clone depth limitation #4105

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

abitrolly
Copy link
Contributor

See #4103

Description

I removed stages key, because copy/pasting the block may break stages that people have defined already.

Motivation and Context

Usage examples

// commitlint.config.js
module.exports = {};
echo "your commit message here" | commitlint # fails/passes

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codesandbox-ci bot commented Jul 26, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Let's keep the example minimal.
@escapedcat
Copy link
Member

escapedcat commented Jul 26, 2024

Thanks!

I removed stages key, because copy/pasting the block may break stages that people have defined already.

You think it's worth adding i.e. a comment for these or just leave it out for now?

@abitrolly
Copy link
Contributor Author

@escapedcat better leave it out for now, because there are more ways to organize when to run then job . For example, use special needs: [] syntax to run it as soon as possible regardless of stage.

https://docs.gitlab.com/ee/ci/pipelines/pipeline_architectures.html#pipelines-with-the-needs-keyword

Failing lint stage also aborts build stage, which may be not what people expect. Probably they want to see if tests pass and fix both tests and lint warnings for the next push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants