-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change monomial equality creation for SMA, k=1 #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also got the same error when using ISMA for K=1. Fixed in 94701ee. |
test this please |
All the tests are passing. Ignore anything other than "gpfit pylint tests" and "gpfit unit tests" |
@mjburton11, there seem to be pylint errors on this? |
bqpd
approved these changes
Dec 21, 2016
Refactor
are the changes to .pylintrc here consistent with those in gpkit? |
Not entirely, because Philippe favoured different variable names than I
did. I think unifying the two would make sense as an issue on this repo,
though.
…On Dec 30, 2016 17:51, "Marshall Galbraith" ***@***.***> wrote:
are the changes to .pylintrc here consistent with those in gpkit?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#59 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABagGFYrT-2J60cdT8u0Ih-j09az4wboks5rNbUhgaJpZM4LKilT>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@whoburg, @bqpd: ready for review:
I've been getting the below error when trying to fit data with SMA, K=1. I believe this PR will fix it.