-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
big pylint refactor #1578
base: master
Are you sure you want to change the base?
big pylint refactor #1578
Conversation
Can one of the admins verify this patch? |
test this please |
1 similar comment
test this please |
Macys is running Python 3.12, where distutils has been deprecated and removed. Unfortunately mosek 9.1 used distutils. I've installed mosek 10.1 to see if that fixes it, or just creates new problems. |
No dice... Mosek uses setuptools as well which is also gone in Python 3.12... |
Gotcha, we probably can't support python 3.12 then until mosek does as well as well. |
Added more commits that address |
I'm at SciTech this week. I won't be able to fix macy's for you to use an older version of Python until some time next week. |
Alright, I bit the bullet and got the entire
gpkit/
package up to date with the latest pylint (pylint 3.0.3). My goal was to reduce custom rcfile settings, use local pylint disable statements where warranted, and get the code base in line with the latest pylint with default settings.I did identify three warnings (disabled in the current PR) that I feel warrant opening issues to address:
solution_array.py
and inconstraints/set.py
modified-iterating-list
warning ininteractive/plotting.py
, warning that a valueparents
used to control iteration in a loop is also being modified within that same loopThis PR currently handles the
gpkit
directory, includinggpkit/tests
, but does not touchdocs/source/examples
at all. That can be the next pylint PR.Review definitely warranted and welcome.