Compose WebMercatorGridPointSet with WebMercatorExtents to reduce duplication #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes test which passes with these changes in place. Also added and updated Javadoc. This is a more minimal changeset than originally proposed, to facilitate review and contain risk from changing heavily used math functions.
This complements forTrimmedWgsEnvelope to handle numerical instability or imprecision in a different case: tight bounds around sets of points that must fall into the resulting grid.
These existed in two places: on Grid and WebMercatorGridPointSet. I retained the more general version that takes a zoom parameter. Math functions were all switched to Java built-in standard Math. We used both FastMath and Java standard Math. FastMath existed because standard Math used to be strict, but Java now has separate StrictMath and standard Math is optimized. This still deserves to be profiled. Also removed IsochroneFeature which is unused, but called some removed functions. IsochroneFeature was ported to JS as Jsolines, and sees destination travel times as being located at the top left corner of Mercator pixels. Removing it eliminates a source of confusion if someone sees unused code using pixel corners.
abyrd
force-pushed
the
merge-extents-with-pointset
branch
from
4bb6947 to
d0f0f9c
Compare
Height and width in WebMercatorGridPointSet constructor were often one unit too narrow (not consistent with WebMercatorExtents).
abyrd
force-pushed
the
merge-extents-with-pointset
branch
from
d0f0f9c to
a095984
Compare
|
Duplicate of #900, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT PR trying out reuse of code from WebMercatorExtents. Some logic was slightly different between the two, this makes it more uniform with less duplication.
Note this branches off of another PR branch, not against dev.